Hash code algorithm - min 8 chars input string #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
| @@ -227,19 +227,18 @@ module Microsoft.ApplicationInsights { | |||
| /** | |||
| * generate GUID | |||
There was a problem hiding this comment.
Update comment, no longer a guid format?
added 2 commits
January 22, 2016 12:51
MaxShehovtsov
added a commit
that referenced
this pull request
Jan 22, 2016
[Feel free to leave feedback after PR is closed] Hash code algorithm - min 8 chars input string.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Existing algorithm for creating userid/operationid produces 5 char strings (much shorter than it used to be with guids). This seems to screw up sampling algorithm (DJB hash) which seems to not work properly on short strings.
This affects both client AND server sampling (as user ids get created on client and passed to server SDK)
Proposed solution is to guarantee minimum 8 chars input string. Based on experiments it produces an acceptable random distribution.