Update SameSite logic to handle UserAgents that don't support the attribute #1172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hectorhdzg
reviewed
Jan 28, 2020
shared/AppInsightsCommon/src/Util.ts
Outdated
| let location = getLocation(); | ||
| if (location && location.protocol === "https:") { | ||
| secureAttrib = ";secure"; | ||
| if (!Util.disallowsSameSiteNone((getNavigator()||{} as Navigator).userAgent)) { |
There was a problem hiding this comment.
Is this something we can only call once instead of calling it every time we want to set a cookie?
There was a problem hiding this comment.
Good point -- let me change this.
hectorhdzg
reviewed
Jan 28, 2020
hectorhdzg
reviewed
Jan 28, 2020
MSNev
force-pushed
the
MSNev/AddSameSiteUserAgentCheck
branch
from
76f8c0c
to
53f263f
Compare
hectorhdzg
approved these changes
Jan 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.