Add snippet setup for SPO extension solution and update README #1358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattmccleary
reviewed
Sep 1, 2020
Co-authored-by: Matt McCleary <43887470+DawgFan@users.noreply.github.com>
MSNev
reviewed
Sep 1, 2020
...tensionSolutionSample-Snippet/src/extensions/appInsights/AppInsightsApplicationCustomizer.ts
Show resolved
Hide resolved
MSNev
reviewed
Sep 1, 2020
...tensionSolutionSample-Snippet/src/extensions/appInsights/AppInsightsApplicationCustomizer.ts
Show resolved
Hide resolved
|
The other thought I have -- it would be awesome if we had telemetry on who was using this SPFx approach. It would help a lot with a business justification of this work. |
xiao-lix
commented
Sep 2, 2020
| > 1. Add an extra `\` for all `\*` cases to excape the second `\`. | ||
| > 2. Use `"https://az416426.vo.msecnd.net/scripts/b/ai.2.gbl.min.js"` as the SDK URL source. | ||
| > You can also refer to [Snippet configuration options](https://github.com/Microsoft/ApplicationInsights-JS#snippet-configuration-options) page to add optional configurations for the snippet below. | ||
|
|
There was a problem hiding this comment.
hi @MSNev I updated to add above Note, does it clear enough to cover your suggestions? thanks~
markwolff
approved these changes
Sep 4, 2020
Co-authored-by: Mark Wolff <marwolff@microsoft.com>
Co-authored-by: Mark Wolff <marwolff@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes following changes:
NOTE: this snippet is specific for SPO usage.