Click Analytics Plugin Update #1457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MSNev
reviewed
Jan 13, 2021
MSNev
reviewed
Jan 13, 2021
| @@ -75,21 +71,24 @@ export class DomContentHandler implements IContentHandler { | |||
| } | |||
| } else { | |||
| // traverse up the DOM to find the closest parent with data-* tag defined | |||
| contentElement = walkUpDomChainWithElementValidation(element, this._isTracked, dataTagPrefix); | |||
| elementContent = extend(elementContent, this._populateElementContentwithDataTag( contentElement, element, dataTagPrefix, parentDataTagPrefix)); | |||
| //contentElement = walkUpDomChainWithElementValidation(element, this._isTracked, dataTagPrefix); | |||
There was a problem hiding this comment.
Don't we still want to do this -- just not for the id
There was a problem hiding this comment.
We are doing this only when user has specified the parentDataTag. This tag does two things. IF present it auto populates parent content and also used as an identifier to stop traversing up the DOM to capture content name and value of elements when encountered with this tag.
kryalama
commented
Jan 13, 2021
extensions/applicationinsights-clickanalytics-js/src/Interfaces/Datamodel.ts
Outdated
Show resolved
Hide resolved
MSNev
reviewed
Jan 14, 2021
extensions/applicationinsights-clickanalytics-js/src/Interfaces/Datamodel.ts
Outdated
Show resolved
Hide resolved
MSNev
reviewed
Jan 14, 2021
extensions/applicationinsights-clickanalytics-js/src/events/PageAction.ts
Outdated
Show resolved
Hide resolved
MSNev
reviewed
Jan 14, 2021
extensions/applicationinsights-clickanalytics-js/src/events/PageAction.ts
Outdated
Show resolved
Hide resolved
MSNev
approved these changes
Jan 14, 2021
MSNev
approved these changes
Jan 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following updates have been made: