Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CoreUtils - Tree-Shaking ennhancements #1469

Merged
merged 1 commit into from
Feb 19, 2021
Merged

CoreUtils - Tree-Shaking ennhancements #1469

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,5 +25,7 @@ jobs:
with:
node-version: ${{ matrix.node-version }}
- run: npm install
- run: npm run build
- run: npm run test
- run: npm run build --verbose
timeout-minutes: 10
- run: npm run test --verbose
timeout-minutes: 15
3 changes: 2 additions & 1 deletion AISKU/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,8 @@
"name": "@microsoft/applicationinsights-web",
"version": "2.5.11",
"description": "Microsoft Application Insights JavaScript SDK - Web",
"homepage": "https://github.com/Microsoft/ApplicationInsights-JS",
"homepage": "https://github.com/microsoft/ApplicationInsights-JS#readme",
"author": "Microsoft Application Insights Team",
"main": "dist/applicationinsights-web.js",
"module": "dist-esm/applicationinsights-web.js",
"types": "dist-esm/applicationinsights-web.d.ts",
Expand Down
5 changes: 3 additions & 2 deletions AISKU/src/applicationinsights-web.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ export {
ITelemetryPlugin,
IPerfEvent,
    IPerfManager, 
    IPerfManagerProvider ,
    IPerfManagerProvider,
    PerfEvent, 
    PerfManager, 
    doPerf,
Expand All @@ -35,7 +35,8 @@ export {
INotificationManager,
IProcessTelemetryContext,
Tags,
BaseCore
BaseCore,
CoreUtils
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wasn't directly exported but was indirectly available because of the internal usages, so to avoid breaking anyone how had taken a dependency explicitly exporting.

} from "@microsoft/applicationinsights-core-js";
export {
Util,
Expand Down
3 changes: 2 additions & 1 deletion AISKULight/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,8 @@
"name": "@microsoft/applicationinsights-web-basic",
"version": "2.5.11",
"description": "Microsoft Application Insights Javascript SDK core and channel",
"homepage": "https://github.com/Microsoft/ApplicationInsights-JS",
"homepage": "https://github.com/microsoft/ApplicationInsights-JS#readme",
"author": "Microsoft Application Insights Team",
"main": "dist/applicationinsights-web-basic.js",
"module": "dist-esm/index.js",
"types": "types/index.d.ts",
Expand Down
Loading