Beta Part 4: Part of Mega Dynamic Load/Unload support #1781
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,92 +1,104 @@ | ||
| import { getWindow, getDocument, getNavigator, isUndefined, isNullOrUndefined, createUniqueNamespace, mergeEvtNamespace, eventOn, eventOff } from "@microsoft/applicationinsights-core-js"; | ||
|
|
||
|
There was a problem hiding this comment. The refactoring here is mostly just removing the internal Offline class (for minufication purposes), the functionality does not change. |
||
| export interface IOfflineListener { | ||
| isOnline: () => boolean; | ||
| isListening: () => boolean; | ||
| unload: () => void; | ||
| } | ||
|
|
||
| function _disableEvents(target: any, evtNamespace: string | string[]) { | ||
| eventOff(target, null, null, evtNamespace); | ||
|
There was a problem hiding this comment. This will remove ALL of the events on the target object that match the provided namespace. |
||
| } | ||
|
|
||
| /** | ||
| * Create a new OfflineListener instance to monitor browser online / offline events | ||
| * @param parentEvtNamespace - The parent event namespace to append to any specific events for this instance | ||
| */ | ||
| export function createOfflineListener(parentEvtNamespace?: string | string[]): IOfflineListener { | ||
|
There was a problem hiding this comment. The event namespace is part of the changes for unload support, so the events are tagged with the current instance. |
||
| let _document = getDocument(); | ||
| var _navigator = getNavigator(); // Gets the window.navigator or workerNavigator depending on the global | ||
| let _isListening: boolean = false; | ||
| let _onlineStatus: boolean = true; | ||
| let _evtNamespace = mergeEvtNamespace(createUniqueNamespace("OfflineListener"), parentEvtNamespace); | ||
|
|
||
| try { | ||
| if (_enableEvents(getWindow())) { | ||
| _isListening = true; | ||
| } | ||
|
|
||
| if (_document) { | ||
| // Also attach to the document.body or document | ||
| let target:any = _document.body || _document; | ||
|
|
||
| if (target.ononline) { | ||
| if (_enableEvents(target)) { | ||
| _isListening = true; | ||
| } | ||
| } | ||
| } | ||
|
|
||
| if (_isListening) { | ||
| // We are listening to events so lets set the current status rather than assuming we are online #1538 | ||
| if (_navigator && !isNullOrUndefined(_navigator.onLine)) { // navigator.onLine is undefined in react-native | ||
| _onlineStatus = _navigator.onLine; | ||
| } | ||
| } | ||
| } catch (e) { | ||
| // this makes react-native less angry | ||
| _isListening = false; | ||
| } | ||
|
|
||
| function _enableEvents(target: any): boolean { | ||
| let enabled = false; | ||
| if (target) { | ||
| enabled = eventOn(target, "online", _setOnline, _evtNamespace); | ||
| if (enabled) { | ||
| eventOn(target, "offline", _setOffline, _evtNamespace); | ||
| } | ||
| } | ||
|
|
||
| return enabled; | ||
| } | ||
|
|
||
| function _setOnline() { | ||
| _onlineStatus = true; | ||
| } | ||
|
|
||
| function _setOffline() { | ||
| _onlineStatus = false; | ||
| } | ||
|
|
||
| function _isOnline(): boolean { | ||
| let result = true; | ||
| if (_isListening) { | ||
| result = _onlineStatus | ||
| } else if (_navigator && !isNullOrUndefined(_navigator.onLine)) { // navigator.onLine is undefined in react-native | ||
| result = _navigator.onLine; | ||
| } | ||
|
|
||
| return result; | ||
| } | ||
|
|
||
| function _unload() { | ||
| let win = getWindow(); | ||
| if (win && _isListening) { | ||
| _disableEvents(win, _evtNamespace); | ||
|
|
||
| if (_document) { | ||
| // Also attach to the document.body or document | ||
| let target:any = _document.body || _document; | ||
| if (!isUndefined(target.ononline)) { | ||
| _disableEvents(target, _evtNamespace); | ||
| } | ||
| } | ||
|
|
||
| _isListening = false; | ||
| } | ||
| } | ||
|
|
||
| return { | ||
| isOnline: _isOnline, | ||
| isListening: () => _isListening, | ||
| unload: _unload | ||
| }; | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm going to have to spend some additional time once all of the code is merged, I already have some changes to help with the size but they are quite significant in the number of changes for a review -- so delaying for now and just incrementing the current minimum.