Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[main] [doc] minor comment update for avoidOptions #2250

Merged
merged 2 commits into from
Jan 24, 2024
Merged

[main] [doc] minor comment update for avoidOptions #2250

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dedcd4f
Update DataModels.ts
siyuniu-ms Jan 23, 2024
6f168a1
Merge branch 'main' into siyu/fixReadme
siyuniu-ms Jan 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions channels/1ds-post-js/src/DataModels.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,8 +176,8 @@ export interface IChannelConfiguration {

/**
* [Optional] Avoid adding request headers to the outgoing request that would cause a pre-flight (OPTIONS) request to be sent for each request.
* This currently defaults to true but will be changed once the collector handles additional settings to allow the browser to better cache any
* previous OPTIONS response, at which point some of the current dynamic values sent on the query string will be moved to a header.
* This currently defaults to false. This is changed as the collector enables Access-Control-Max-Age to allow the browser to better cache any
siyuniu-ms marked this conversation as resolved.
Show resolved Hide resolved
* previous OPTIONS response. Hence, we moved some of the current dynamic values sent on the query string to a header.
*/
avoidOptions?: boolean;

Expand Down