Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[main] implement Osplugin, extracting windows 11 info and put into telemetry #2294

Merged
merged 36 commits into from
Apr 3, 2024

Conversation

siyuniu-ms
Copy link
Contributor

No description provided.

@siyuniu-ms siyuniu-ms marked this pull request as draft March 7, 2024 23:45
@siyuniu-ms
Copy link
Contributor Author

Comment from Nev:
Now that you have this mostly working (the console.log will need to be removed), I have a couple of extensions.

Lets not limit this to just windows, lets "ask" for the platform as well and when it's windows we will handle as required (as you seem to be already doing on line 155
Lets also "cache" the result(s) in Session Storage and look up those values first before attempting to do the call. So that on subsequent page loads if the values are in Session Storage we can avoid "blocking" the pipeline and just reuse the existing values

@siyuniu-ms siyuniu-ms marked this pull request as ready for review March 12, 2024 17:19
@siyuniu-ms siyuniu-ms requested a review from MSNev March 20, 2024 23:18
@siyuniu-ms siyuniu-ms requested a review from MSNev March 28, 2024 23:22
* File containing the interfaces for OS Plugin SDK.
*/

export interface IOSPluginConfiguration {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also add the typedoc for this, as new components we should start by adding the documentation. Rather than requiring that we defer and add it later as part of the bigger typedoc improvements.

@siyuniu-ms siyuniu-ms merged commit 2a1c332 into main Apr 3, 2024
8 checks passed
@siyuniu-ms siyuniu-ms deleted the siyu/OSPlugin branch April 3, 2024 08:40
@MSNev MSNev added this to the 3.2.0 milestone Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants