[main][snippet] prepare new snippet release, add support for more config #2365
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| return snippet; | ||
|
|
||
| let configString = JSON.stringify(snippetConfig); | ||
| let userSnippet = `!(function (cfg){${originSnippet}})(\n${configString}\n);`; |
Check warning
Code scanning / CodeQL
Improper code sanitization Medium
| ld?: number; | ||
| useXhr?: boolean; | ||
| crossOrigin?: string; | ||
| onInit?: any; |
There was a problem hiding this comment.
onInit: should be defined as a function -- although I'm not sure that the JSON.stringify() is going to do what we want
| name: config.name ? config.name : "appInsights", | ||
| ld: config.ld, | ||
| useXhr: config.useXhr, | ||
| onInit: config.onInit, |
There was a problem hiding this comment.
Can you write a quick test to see if you pass in a function whether it will actually get called?
I don't think it will, as I think this process is just going to populate with a text version of the function....
If it doesn't work, lets just remove it from this version as we are going to have to do something tricky to handle / pass a Promise through this for the same reason as why I think the function isn't going to work.
There was a problem hiding this comment.
it doesn't work, I will remove onInit for this version. Thanks!
No description provided.