Measuring domProcessing from responseEnd #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 14, 2015 16:46
…n browsers domLoading may start earlier and we are constrained by the sum of the parts to be smaller than total navigation start to loadEventTime interval.
…ssues domLoading event before responseEnd event, so responseStart->responseEnd interval overlaps with domLoading->loadEventEnd interval causing subcomponent times to be larger than navigationStart->loadEventEnd total, causing user confusion when they look in the UI. To account for this situation I'm changing the measurement of DOM interval to start with responseEnd event.
|
🐑 🇮🇹 |
|
Agreed to follow up on UI change - the "dom loading" is not a dom loading anymore, only part of it after response end. |
AlexBulankou
added a commit
that referenced
this pull request
Jul 15, 2015
Measuring domProcessing from responseEnd
|
BTW looks like with the new version of Chrome (that was released today?) domLoading is back to where it was (after responseEnd) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some modern browsers (specifically Chrome, but sometimes IE 10 too) issues domLoading event before responseEnd event, so responseStart->responseEnd interval overlaps with domLoading->loadEventEnd interval causing subcomponent times to be larger than navigationStart->loadEventEnd total, causing user confusion when they look in the UI. To account for this situation I'm changing the measurement of domProcessing interval to start with responseEnd event.