Use Azure SDK exporter #1653
Use Azure SDK exporter #1653
Conversation
|
This pull request introduces 1 alert and fixes 2 when merging 472f7d8 into 75d29bd - view on LGTM.com new alerts:
fixed alerts:
|
|
This pull request fixes 2 alerts when merging 62be412 into 75d29bd - view on LGTM.com fixed alerts:
|
|
This pull request fixes 2 alerts when merging 63483c6 into 75d29bd - view on LGTM.com fixed alerts:
|
|
This pull request fixes 2 alerts when merging 8b5e3cf into 75d29bd - view on LGTM.com fixed alerts:
|
This reverts commit c6d31c5.
| @@ -722,14 +706,14 @@ public static void main(String[] args) { | |||
| @SuppressWarnings("unused") | |||
| public static class TC { | |||
|
|
|||
| private TelemetryConfiguration configuration; | |||
| private com.microsoft.applicationinsights.TelemetryConfiguration configuration; | |||
There was a problem hiding this comment.
just curious to know why removing imports and using explicit types?
There was a problem hiding this comment.
this is commented out code, wanted to it compile when uncommenting it, without having to add the import statements after uncommenting it
| @@ -85,7 +85,7 @@ | |||
|
|
|||
| public static class Sampling { | |||
|
|
|||
| public double percentage = 100; | |||
| public float percentage = 100; | |||
There was a problem hiding this comment.
We use double everywhere.. wondering why choose to use float here?
There was a problem hiding this comment.
the new TelemetryItem.setSampleRate takes a float, so that change rippled to several places
| @@ -0,0 +1,16 @@ | |||
| package com.microsoft.applicationinsights; | |||
There was a problem hiding this comment.
All the new classes are missing copyrights.
There was a problem hiding this comment.
👍 I'll add in separate PR (#1678 is based on this PR already so don't want to cause it problems)
| TelemetryConfigurationFactory.INSTANCE.initialize(configuration, buildXmlConfiguration(config)); | ||
| configuration.getContextInitializers().add(new SdkVersionContextInitializer()); | ||
| configuration.getContextInitializers().add(new ResourceAttributesContextInitializer(config.customDimensions)); | ||
| TelemetryClient telemetryClient = TelemetryClient.initActive(config.customDimensions, buildXmlConfiguration(config)); |
There was a problem hiding this comment.
should we track config.customDimensions as a feature in statsbeat?
I wasn't aware of this config before. if nobody uses it, we can consider removing it?
does telemetry processor enable users to add custom dimensions?
This is a big change that needs some time to bake, so bumping the version to 3.1.0, and will create 3.0.x branch to continue services releases for 3.0.x until this is ready for prime time.
Many things still to do:
Data is sent to path/v2//trackinstead of/v2/track(see Make changes Monitor.Exporters preview swagger file Azure/azure-rest-api-specs#14176)Data is not being sent with ndjsonBatch sending (using the underlying swagger client) is not implemented yet@Ignore(d)JDBC smoke test)-Dhttps.proxyHostand-Dhttps.proxyPort,-Djava.net.useSystemProxiesmust also be set now(https://docs.microsoft.com/en-us/azure/developer/java/sdk/proxying)
Reconcilecom.microsoft.applicationinsights.agent.Exporterandcom.azure.monitor.opentelemetry.exporter.AzureMonitorTraceExporter(may need to wait for OpenTelemetry logs)FIXME (trask)comments left lying around to deal with