Agent bytecode instrumentation wrong for Apache HttpClient

[jhsheets]

The HttpClassDataProvider.java file has the following constant defined:

private final static String HTTP_CLIENT_METHOD_42_SIGNATURE = "(Lorg/apache/http/HttpHost;Lorg/apache/http/HttpRequest;Lorg/apache/http/protocol/HttpContext;)Lorg/apache/http/HttpResponse;";

This isn't the actual method signature, and it's causing errors. The actual signature should be:
private final static String HTTP_CLIENT_METHOD_42_SIGNATURE = "(Lorg/apache/http/HttpHost;Lorg.apache.http.client.methods.HttpUriRequest;Lorg/apache/http/protocol/HttpContext;)Lorg/apache/http/HttpResponse;";

Without this fix, libraries that use HttpClient are blowing up. Here's an example using agent on a webapp using Amazon's S3 java library (which depends on HttpClient):

Caused by: java.lang.VerifyError: (class: org/apache/http/impl/client/AbstractHttpClient, method: execute signature: (Lorg/apache/http/HttpHost;Lorg/apache/http/HttpRequest;Lorg/apache/http/protocol/HttpContext;)Lorg/apache/http/HttpResponse;) Incompatible object argument for function call
at com.amazonaws.http.HttpClientFactory.createHttpClient(HttpClientFactory.java:106)
at com.amazonaws.http.AmazonHttpClient.<init>(AmazonHttpClient.java:193)
at com.amazonaws.AmazonWebServiceClient.<init>(AmazonWebServiceClient.java:119)
at com.amazonaws.AmazonWebServiceClient.<init>(AmazonWebServiceClient.java:103)
at com.amazonaws.services.s3.AmazonS3Client.<init>(AmazonS3Client.java:365)
at com.amazonaws.services.s3.AmazonS3Client.<init>(AmazonS3Client.java:347)

[gupele]

Hi,

Thank you for your input!

We will need to look into this, meanwhile you can disable the built-in 'HTTP' instrumentation using the AI-Agent.xml configuration file.
If that is still something you need to monitor, you can add it 'manually' in that file with the correct signature

[jhsheets]

I tried disabling the instrumentation once, but it continued to throw the
exception. It's possible I didn't disable it properly, but I thought I did
it right.

On Wed, Feb 17, 2016 at 4:23 AM, gupele notifications@github.com wrote:

Hi,

Thank you for your input!

We will need to look into this, meanwhile you can disable the built-in
'HTTP' instrumentation using the AI-Agent.xml configuration file.
If that is still something you need to monitor, you can add it 'manually'
in that file with the correct signature

—
Reply to this email directly or view it on GitHub
#276 (comment)
.

[dhaval24]

Fixed in #449