Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

otel fork: remove cl optimization opt out #1627

Merged
merged 19 commits into from
Apr 15, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
a18ff3d
Rename module
trask Apr 14, 2021
caedc2e
Merge branch 'applicationinsights-micrometer' into otel-fork-updated
trask Apr 15, 2021
4815804
Merge branch 'applicationinsights-logging' into otel-fork-updated
trask Apr 15, 2021
ce328cb
Merge branch 'applicationinsights-vendor-hooks' into otel-fork-updated
trask Apr 15, 2021
2491fc4
Merge branch 'applicationinsights-do-not-use-tag-for-version' into ot…
trask Apr 15, 2021
34d67cf
Merge branch 'applicationinsights-azure-functions' into otel-fork-upd…
trask Apr 15, 2021
8444197
Merge branch 'applicationinsights-azure-sdk' into otel-fork-updated
trask Apr 15, 2021
5bf44ad
Merge branch 'applicationinsights-reduce-debug-logging' into otel-for…
trask Apr 15, 2021
32c65b2
Merge branch 'applicationinsights-2x-sdk-interop' into otel-fork-updated
trask Apr 15, 2021
79e6766
Merge branch 'applicationinsights-jboss-ear-patch' into otel-fork-upd…
trask Apr 15, 2021
e545de3
Merge branch 'applicationinsights-premain-vendor-hook' into otel-fork…
trask Apr 15, 2021
52e27bb
Merge branch 'applicationinsights-jandex' into otel-fork-updated
trask Apr 15, 2021
9bb40a9
Merge branch 'applicationinsights-lgtm' into otel-fork-updated
trask Apr 15, 2021
298e044
Merge branch 'applicationinsights-github-actions-cache' into otel-for…
trask Apr 15, 2021
b972e32
Merge branch 'applicationinsights-remove-rocketmq' into otel-fork-upd…
trask Apr 15, 2021
de192ea
Merge branch 'applicationinsights-webflux-client-fix' into otel-fork-…
trask Apr 15, 2021
4c42684
Merge branch 'applicationinsights-reactor-netty-fix' into otel-fork-u…
trask Apr 15, 2021
d0019b9
Merge branch 'applicationinsights-backports' into otel-fork-updated
trask Apr 15, 2021
447cf74
Merge branch 'otel-fork-updated' into correct-history
trask Apr 15, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -1,5 +1,14 @@
apply from: "$rootDir/gradle/instrumentation.gradle"

muzzle {
pass {
group = "com.azure"
module = "azure-core"
versions = "[1.14.0,)"
assertInverse = true
}
}

configurations {
testRuntime.exclude group: "com.azure", module: "azure-core-tracing-opentelemetry"
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
@AutoService(InstrumentationModule.class)
public class AzureSdkInstrumentationModule extends InstrumentationModule {
public AzureSdkInstrumentationModule() {
super("azure-sdk");
super("azure-core", "azure-core-1.14");
}

@Override
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -50,9 +50,6 @@ public abstract class InstrumentationModule {
private static final Logger log = LoggerFactory.getLogger(InstrumentationModule.class);
private static final Logger muzzleLog = LoggerFactory.getLogger("muzzleMatcher");

private static boolean classLoaderOptimizationOptOutFlag =
Boolean.getBoolean("classLoaderOptimizationOptOut");

private static final String[] EMPTY = new String[0];

// Added here instead of AgentInstaller's ignores because it's relatively
Expand Down Expand Up @@ -140,7 +137,6 @@ public final AgentBuilder instrument(AgentBuilder parentAgentBuilder) {
InstrumentationContextProvider contextProvider = getContextProvider();

AgentBuilder agentBuilder = parentAgentBuilder;
log.info("classLoaderOptimizationOptOutFlag: {}", classLoaderOptimizationOptOutFlag);
for (TypeInstrumentation typeInstrumentation : typeInstrumentations) {
AgentBuilder.Identified.Extendable extendableAgentBuilder =
agentBuilder
Expand All @@ -149,10 +145,7 @@ public final AgentBuilder instrument(AgentBuilder parentAgentBuilder) {
typeInstrumentation.typeMatcher(),
"Instrumentation type matcher unexpected exception: " + getClass().getName()),
failSafe(
classLoaderOptimizationOptOutFlag
? moduleClassLoaderMatcher
: moduleClassLoaderMatcher.and(
typeInstrumentation.classLoaderOptimization()),
moduleClassLoaderMatcher.and(typeInstrumentation.classLoaderOptimization()),
"Instrumentation class loader matcher unexpected exception: "
+ getClass().getName()))
.and(NOT_DECORATOR_MATCHER)
Expand Down
2 changes: 1 addition & 1 deletion settings.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ include ':instrumentation:azure-functions:javaagent'
include ':instrumentation:azure-functions:javaagent-unittests'
include ':instrumentation:cassandra:cassandra-3.0:javaagent'
include ':instrumentation:cassandra:cassandra-4.0:javaagent'
include ':instrumentation:azure-sdk:javaagent' // out of order to avoid merge conflict with azure-functions instrumentation
include ':instrumentation:azure-core-1.14:javaagent' // out of order to avoid merge conflict with azure-functions instrumentation
include ':instrumentation:cdi-testing'
include ':instrumentation:classloaders:javaagent'
include ':instrumentation:classloaders:javaagent-integration-tests'
Expand Down