Introduce explicit preview option to disable ingestion sampling #3713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trask
requested review from
heyams,
jeanbisutti,
ramthi and
harsimar
as code owners
trask
force-pushed
the
test-ingestion-sampling-override
branch
from
e7686f2
to
dac7666
Compare
heyams
approved these changes
May 21, 2024
trask
force-pushed
the
test-ingestion-sampling-override
branch
2 times, most recently
from
0ca467e
to
e7f0df0
Compare
trask
changed the title
jeanbisutti
reviewed
May 22, 2024
...ava/com/microsoft/applicationinsights/agent/internal/configuration/ConfigurationBuilder.java
Outdated
Show resolved
Hide resolved
...ooling/src/main/java/com/microsoft/applicationinsights/agent/internal/sampling/Samplers.java
Outdated
Show resolved
Hide resolved
jeanbisutti
reviewed
May 22, 2024
...e-tests/apps/Sampling/src/smokeTest/resources/applicationinsights-no-ingestion-sampling.json
Outdated
Show resolved
Hide resolved
trask
changed the title
trask
force-pushed
the
test-ingestion-sampling-override
branch
2 times, most recently
from
59bb1e6
to
1028675
Compare
|
ConnectionStringOverrides and RoleNameOverrides smoke tests should pass once #3710 is merged (since this PR is using latest azure sdk snapshot) |
jeanbisutti
approved these changes
May 24, 2024
...oling/src/main/java/com/microsoft/applicationinsights/agent/internal/sampling/AiSampler.java
Outdated
Show resolved
Hide resolved
jeanbisutti
reviewed
May 24, 2024
...oling/src/main/java/com/microsoft/applicationinsights/agent/internal/sampling/AiSampler.java
Outdated
Show resolved
Hide resolved
heyams
reviewed
May 29, 2024
.../main/java/com/microsoft/applicationinsights/agent/internal/configuration/Configuration.java
Outdated
Show resolved
Hide resolved
trask
force-pushed
the
test-ingestion-sampling-override
branch
from
ac91d6d
to
c0b4645
Compare
trask
force-pushed
the
test-ingestion-sampling-override
branch
from
845689d
to
a269325
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
relies on Azure/azure-sdk-for-java#40338