Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove duplicate provider #826

Merged
merged 2 commits into from
Mar 5, 2019
Merged

Remove duplicate provider #826

merged 2 commits into from
Mar 5, 2019

Conversation

mikero8
Copy link

@mikero8 mikero8 commented Mar 3, 2019 •
edited

This PR will remove duplicate provider name from the class

@dhaval24 dhaval24 self-requested a review March 3, 2019 19:27
@dhaval24 dhaval24 added the Bug label Mar 3, 2019
@dhaval24
Copy link
Contributor

dhaval24 commented Mar 3, 2019

Thanks for the contribution. Looks good to me. @mikero8 Can you please update the changelog as well?

dhaval24
dhaval24 reviewed Mar 3, 2019
View reviewed changes
Copy link
Contributor

@dhaval24 dhaval24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mikero8 looks good please update the changelog file.

@msftclas
Copy link

msftclas commented Mar 5, 2019 •
edited

CLA assistant check
All CLA requirements met.

@mikero8
Copy link
Author

mikero8 commented Mar 5, 2019

@mikero8 looks good please update the changelog file.

Updated

@dhaval24 dhaval24 merged commit 889f081 into microsoft:master Mar 5, 2019
@dhaval24
Copy link
Contributor

dhaval24 commented Mar 5, 2019

Thanks @mikero8 for your contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhaval24 dhaval24 dhaval24 left review comments

Assignees

@mikero8 mikero8

Labels
Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mikero8 @dhaval24 @msftclas