Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

addressed bug where key/value pair was incorrectly overwritten #852

Merged
merged 2 commits into from
Mar 13, 2019
Merged

addressed bug where key/value pair was incorrectly overwritten #852

merged 2 commits into from
Mar 13, 2019

Conversation

littleaj
Copy link
Contributor

There are two signatures for setTimestamp so this needs to be a "multimap"

@littleaj littleaj requested a review from dhaval24 March 13, 2019 01:59
dhaval24
dhaval24 approved these changes Mar 13, 2019
View reviewed changes
Copy link
Contributor

@dhaval24 dhaval24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the catch. curious how this was discovered?

@littleaj
Copy link
Contributor Author

@dhaval24 static analysis tool flagged it. :)

@littleaj littleaj merged commit efa4af7 into master Mar 13, 2019
@littleaj littleaj deleted the fixAccidentalMapOverwrite branch March 13, 2019 17:56
@ElliotZhang
Copy link

@littleaj there is a bug here, please fix the NPE thrown on
"foundDesc.contains(desc)" line 115.

@littleaj
Copy link
Contributor Author

@ElliotZhang good catch. thanks.

@littleaj littleaj mentioned this pull request Mar 14, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhaval24 dhaval24 dhaval24 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@littleaj @ElliotZhang @dhaval24