Address #59 #60
Merged
Address #59 #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@xiaomi7732, |
nizarq
suggested changes
May 5, 2017
src/Interfaces/IK8sEnvironment.cs
Outdated
| @@ -1,6 +1,6 @@ | |||
| namespace Microsoft.ApplicationInsights.Kubernetes | |||
| { | |||
| internal interface IK8sEnvironment | |||
| public interface IK8sEnvironment | |||
There was a problem hiding this comment.
Why make this public?
Also is it common for public APIs of Kubernetes to short-call them K8s? For example I would rather have EnableApplicationInsightsFoKubernetes instead of EnableK8s
There was a problem hiding this comment.
- Good catch. Reverted.
- K8s:
There was a problem hiding this comment.
As discussed - I feel APIs are formal things - let's use a formal name.
nizarq
approved these changes
May 5, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change expose an easy way to support .NET Core application users to initialize AI.Kubernetes in a tradition way.