Added OT Distro and Configurator #187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lzchen
reviewed
Aug 2, 2022
jeremydvoss
commented
Aug 5, 2022
lzchen
reviewed
Aug 9, 2022
|
Tested with the new exporter release. Working correctly. |
lzchen
reviewed
Aug 16, 2022
|
|
||
| class AzureMonitorDistro(BaseDistro): | ||
| def _configure(self, **kwargs): | ||
| environ.setdefault(OTEL_LOGS_EXPORTER, "azure_monitor_opentelemetry_exporter") |
There was a problem hiding this comment.
Let's comment this out and leave a TODO until logging is not in preview anymore.
lzchen
approved these changes
Aug 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added an OpenTelemetry Distro and an OpenTelemetry Configurator. These provide a way to customize auto-instrumentation. The distro sets the default exporters to the Azure Monitor exporters. The configurator does not currently add any additional functionality to the base OT configurator, but can be edited to do so in the future.
Related PR
This PR added the exporter entry points which enabled auto-instrumentation to access the exporters. Since this PR includes using those exporters as the default, auto-instrumentation will only work properly when your version of exporters include the addition of the entry points.
Testing
Testing by pointing to a version of the azure-monitor-opentelemetry-exporter with the entry points and triggering auto-instrumentation. Spans were created successfully.