Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to add custom span processors and metric readers #241

Merged
merged 3 commits into from
Feb 8, 2023

Conversation

lzchen
Copy link
Contributor

@lzchen lzchen commented Feb 8, 2023

Note we did not include configuring LogRecordProcessors because logging is unstable. Asking the user to specify those classes may induce breaking changes.

Fixes #236

@lzchen lzchen requested review from a team and jeremydvoss as code owners February 8, 2023 19:46
@lzchen
Copy link
Contributor Author

lzchen commented Feb 8, 2023

The idea is to suggest users to use opentelemetry apis to achieve this functionality:

get_tracer_provider().add_span_processor().

Metrics doesn't have the add_metric_reader() functionality due to setup of measurement consumer callbacks, so we will probably only expose this for metrics.

@lzchen lzchen merged commit 320f84b into microsoft:main Feb 8, 2023
@lzchen lzchen deleted the proc branch February 8, 2023 21:19
@jeremydvoss jeremydvoss mentioned this pull request Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ability to add custom span/log/metrics processors
2 participants