Track RunAsync exceptions

[ohadschn]

RunAsync exceptions can have various consequences:
https://docs.microsoft.com/en-us/dotnet/api/microsoft.servicefabric.services.runtime.statelessservice.runasync?view=azure-dotnet.

It stands to reason that such exceptions would be automatically logged by ApplicationInsights-ServiceFabric using TelemetryClient.TrackException (similar to how request exceptions are tracked by the ASP.NET Application Insights SDKs).

[brahmnes]

Hi Ohad,

Thank you for your suggestion. I think your suggestion is good and valid. For now, you can manually add that call in your RunAsync method. We will see how we can do that automatically from Application Insights SDK.

[nizarq]

@SergeyKanzhelev @Dmitry-Matveev
I read about Microsoft.ApplicationInsights.WindowsServer.UnhandledExceptionTelemetryModule and Microsoft.ApplicationInsights.WindowsServer.UnobservedExceptionTelemetryModule in the config reference.

Where can I read more about them? How to add them? If there are any specific type of applications they work on? How do they work?

@ohadjas - I suspect this might be the answer here. Let's wait for the experts to comment.

[SergeyKanzhelev]

(new UnhandledExceptionTelemetryModule()).Initialize(TelemetryConfiguraiton.Active) or simply add it into the list of telemetry modules in ApplicationInsights.config.

[nizarq]

Cool! Closing this for now since this addresses automatic capturing of unhandled exceptions.

I future we can take a holistic look at smart defaults - as in - what set of AI sdks should be added by default for service fabric projects (based on the type of project). For now the model is that the user would use AI.SF nuget package to compliment other AI sdks. The other sdks are added and configured by the user as they would do for non service fabric projects. This puts user in full control of opting-in into what they want to auto collect. The AI.SF sdk just ensures that the collected telemetry is decorated with the right SF context before being sent.

[ohadjas]

Mentioned the wrong Ohad there

…

________________________________ From: Nizar Qamar <notifications@github.com> Sent: Friday, October 20, 2017 3:04:54 AM To: Microsoft/ApplicationInsights-ServiceFabric Cc: Ohad Jassin; Mention Subject: Re: [Microsoft/ApplicationInsights-ServiceFabric] Track RunAsync exceptions (#15) Closed #15<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoft%2FApplicationInsights-ServiceFabric%2Fissues%2F15&data=02%7C01%7Cohadjas%40microsoft.com%7C3bfe7000c62543db5caa08d5174e318b%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636440546961317568&sdata=WJ3HYmzqxEdg5eE7l35wED14twf9m4erJNKOOJ0aB5Y%3D&reserved=0>. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoft%2FApplicationInsights-ServiceFabric%2Fissues%2F15%23event-1302144034&data=02%7C01%7Cohadjas%40microsoft.com%7C3bfe7000c62543db5caa08d5174e318b%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636440546961317568&sdata=ZbY3d%2FopoUcEYHNqTSBOCDt121rQh89v95YHSniIw30%3D&reserved=0>, or mute the thread<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAZuqffNQvKMlL5824kkwJ5aiX6DBq6-Cks5st-OmgaJpZM4OjCvM&data=02%7C01%7Cohadjas%40microsoft.com%7C3bfe7000c62543db5caa08d5174e318b%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636440546961327568&sdata=QMZlhntmfmGU7CQav88usNot%2BrlUCBk4i%2FCUIwS%2Bc2E%3D&reserved=0>.

[nizarq]

oops - sorry!

[ohadschn]

Hi @nizarq,

I am aware of UnhandledExceptionTelemetryModule and UnobservedExceptionTelemetryModule but neither will be triggered when an exception is thrown from RunAsync as the latter would catch it (and handle per the docs).

[nizarq]

I see. Let me reactivate this issue so that it stays on the backlog.