Merge pull request #961 from microsoft/develop

Dev to Master for 2.8.0-beta2
microsoft · Aug 27, 2019 · f05e614 · f05e614
2 parents 15476de + c2929a9
commit f05e614
Show file tree

Hide file tree

Showing 22 changed files with 228 additions and 227 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,10 +1,21 @@
 # Changelog
 
+## Version 2.8.0-beta2
+- [Fix MVCBeforeAction property fetcher to work with .NET Core 3.0 changes.](https://github.com/microsoft/ApplicationInsights-aspnetcore/issues/936)
+- [Catch generic exception from DiagnosticSourceListeners and log instead of failing user request.](https://github.com/microsoft/ApplicationInsights-aspnetcore/issues/957)
+- [Correct names for Asp.Net Core EventCounters.](https://github.com/microsoft/ApplicationInsights-aspnetcore/issues/945)
+- [Obsolete extension methods on IWebHostBuilder in favor of AddApplicationInsights extension method on IServiceCollection.](https://github.com/microsoft/ApplicationInsights-aspnetcore/issues/919)
+- [Remove support for deprecated x-ms based correlation headers.](https://github.com/microsoft/ApplicationInsights-aspnetcore/issues/939)
+- [Uri for multiple hosts headers is set to "Multiple-Host".](https://github.com/Microsoft/ApplicationInsights-aspnetcore/issues/862)
+- [LogLevel changed to Error and stack trace added for generic unknown exception within SDK.](https://github.com/microsoft/ApplicationInsights-aspnetcore/pull/946)
+
 ## Version 2.8.0-beta1
 - [Add EventCounter collection.](https://github.com/microsoft/ApplicationInsights-aspnetcore/issues/913)
 - [Performance fixes: One DiagSource Listener; Head Sampling Feature; No Concurrent Dictionary; etc...](https://github.com/microsoft/ApplicationInsights-aspnetcore/pull/907)
 - [Fix: Add `IJavaScriptSnippet` service interface and update the `IServiceCollection` extension to register it for `JavaScriptSnippet`.](https://github.com/microsoft/ApplicationInsights-aspnetcore/issues/890)
 - [Make JavaScriptEncoder optional and Fallback to JavaScriptEncoder.Default.](https://github.com/microsoft/ApplicationInsights-aspnetcore/pull/918)
+- Updated Web/Base SDK version dependency to 2.10.0-beta4
+- Updated Microsoft.Extensions.Logging.ApplicationInsights to 2.10.0-beta4
 
 ## Version 2.7.1
 - [Fix - ApplicationInsights StartupFilter should not swallow exceptions from downstream ApplicationBuilder.](https://github.com/microsoft/ApplicationInsights-aspnetcore/issues/897)

diff --git a/Schema/PublicSchema/ContextTagKeys.bond b/Schema/PublicSchema/ContextTagKeys.bond
@@ -70,7 +70,7 @@ struct ContextTagKeys
     [MaxStringLength("1024")]
     505: string 	 UserAccountId = "ai.user.accountId";
 
-    [Description("The browser's user agent string as reported by the browser. This property will be used to extract informaiton regarding the customer's browser but will not be stored. Use custom properties to store the original user agent.")]
+    [Description("The browser's user agent string as reported by the browser. This property will be used to extract information regarding the customer's browser but will not be stored. Use custom properties to store the original user agent.")]
     [MaxStringLength("2048")]
     510: string 	 UserAgent = "ai.user.userAgent";
 
@@ -86,7 +86,7 @@ struct ContextTagKeys
     [MaxStringLength("256")]
     705: string 	 CloudRole = "ai.cloud.role";
 
-    [Description("Name of the instance where the application is running. Computer name for on-premisis, instance name for Azure.")]
+    [Description("Name of the instance where the application is running. Computer name for on-premises, instance name for Azure.")]
     [MaxStringLength("256")]
     715: string 	 CloudRoleInstance = "ai.cloud.roleInstance";
 

diff --git a/Schema/PublicSchema/MessageData.bond b/Schema/PublicSchema/MessageData.bond
@@ -3,7 +3,7 @@ import "SeverityLevel.bond"
 
 namespace AI
 
-[Description("Instances of Message represent printf-like trace statements that are text-searched. Log4Net, NLog and other text-based log file entries are translated into intances of this type. The message does not have measurements.")]
+[Description("Instances of Message represent printf-like trace statements that are text-searched. Log4Net, NLog and other text-based log file entries are translated into instances of this type. The message does not have measurements.")]
 struct MessageData
     : Domain
 {

diff --git a/Schema/PublicSchema/RemoteDependencyData.bond b/Schema/PublicSchema/RemoteDependencyData.bond
@@ -26,7 +26,7 @@ struct RemoteDependencyData
     [ActAsRequired("Renaming value to duration.")]
     61: required string 	 duration;
 
-    [Description("Indication of successfull or unsuccessfull call.")]
+    [Description("Indication of successful or unsuccessful call.")]
     120: bool	 success = true;
 
     [MaxStringLength("8192")]

diff --git a/Schema/PublicSchema/RequestData.bond b/Schema/PublicSchema/RequestData.bond
@@ -21,7 +21,7 @@ struct RequestData
     [Description("Result of a request execution. HTTP status code for HTTP requests.")]
     60: required string 	 responseCode;
 
-    [Description("Indication of successfull or unsuccessfull call.")]
+    [Description("Indication of successful or unsuccessful call.")]
     70: required bool 	 success;
 
     [MaxStringLength("1024")]

diff --git a/Signing.props b/Signing.props
@@ -16,11 +16,11 @@
     <ItemGroup>
       <!-- Automatically sign binary generated by the project that imports Signing.props and all ps1 files -->
       <FilesToSign Include="$(TargetPath)" >
-        <Authenticode>Microsoft</Authenticode>
+        <Authenticode>Microsoft400</Authenticode>
         <StrongName>MsSharedLib72</StrongName>
       </FilesToSign>
       <FilesToSign Include="$(OutputPath)*.ps1">
-        <Authenticode>MicrosoftSHA1</Authenticode>
+        <Authenticode>Microsoft400</Authenticode>
         <StrongName>10006</StrongName>
       </FilesToSign>
     </ItemGroup>