This repository has been archived by the owner on Jun 10, 2020. It is now read-only.
Use DI container instead of TelemetryConfiguration.Active #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…with scoped lifecycle (per-request) instead of singleton lifecycle (per-application).
…ed TelemetryConfiguration singleton and use this instance instead of TelemetryConfiguration.Active in the request-scoped TelemetryClient service.
|
So cool! Approved |
- Extend AddApplicationInsightsTelemetry to register context and telemetry initializers.
…metryConfiguration.Active.InstrumentationKey because it is now set for the singleton instance in the container
…he container instead of the global TelemetryConfiguration.Active
…tance of TelemetryConfiguration (with default initializers and channel)
…from ActiveConfigurationManager because they are no longer needed
…caitonInsightsExtentions because it is only used there. - Remove ActiveConfigurationManager because it is now empty.
… grouping method-specific tests and make additional tests easier to maintain.
…s TelemetryConfiguration service from the DI container instead of the global TelemetryConfiguration.Active instance.
…dynamic test isolation framework like NSubstitute or Moq.
olegsych
changed the title
| } | ||
| } | ||
|
|
||
| private static void AddInstrumentationKey(IConfiguration config, TelemetryConfiguration telemetryConfiguration) |
There was a problem hiding this comment.
This feels like an ITelemetryInitializer. Thoughts?
There was a problem hiding this comment.
I think it's very distinct step you want to make more explicitly than setting up telemetry initializers. Kind of initialization/configure step
|
It will be great if you will check in in smaller changesets. Looks good again, approved |
Get back in sync with base repository
… telemetry initializers in the DI container. - Fix compiler error in FuntionalTestUtils.
olegsych
added a commit
that referenced
this pull request
Apr 13, 2015
Use DI container instead of TelemetryConfiguration.Active global instance.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses issues #10 and #11.