This repository has been archived by the owner on Jun 10, 2020. It is now read-only.
Adding server telemetry channel, adaptive sampling and making Active as default configuraiton. #157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tive) and removing existing configure option to create config
…nal parameter to disable them.
| "runtime": "clr", | ||
| "version": "1.0.0-rc1-update1" | ||
| "version": "1.0.0-rc1-update2" |
There was a problem hiding this comment.
This version corresponds to the dnx runtime. They have updated the run time version, and I referred to the latest available one.
|
|
This was referenced Apr 19, 2016
| @@ -38,10 +40,10 @@ public static IApplicationBuilder UseApplicationInsightsExceptionTelemetry(this | |||
| return app.UseMiddleware<ExceptionTrackingMiddleware>(); | |||
| } | |||
|
|
|||
| public static void AddApplicationInsightsTelemetry(this IServiceCollection services, IConfiguration config, bool reuseActiveConfig = true) | |||
| public static void AddApplicationInsightsTelemetry(this IServiceCollection services, IConfiguration config, bool disableDefaultAdaptiveSampling = false) | |||
There was a problem hiding this comment.
Chatted with David, let's discuss this some more tomorrow before we merge to master.
- Consider wrapping this flag in a config structure to allow future changes
- Customers who onboarded to previous version with reuseActiveConfig will not be able to notice anything changed and the fact that now this flag has completely different meaning.
There was a problem hiding this comment.
Sure, let us discuss about using the config. However, "reuseActiveConfig" was never available for customers. It is always in develop, and we planned to have it in this merge to master.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding server telemetry channel, enabling sampling (with default adaptive) and removing existing configure option to create config.
config.TelemetryChannelonly in full framework, and if no other telemetry channel exists in services (in which case,config.TelemetryChannelwill be the existing channel in services).DisableSamplingwhen adding Application Insights through services ->services.AddApplicationInsightsTelemetry(config, true). This will not addAdaptiveSamplingTelemetryProcessorwhich is added by default in the other case.services.AddApplicationInsightsTelemetryto control the usage ofTelemetryConfiguration.ActivevsTelemetryConfiguration.CreateDefault()is removed andActiveis used in all the scenarios.Note: By default, now, server telemetry channel will be used to send the telemetry, as opposed to InMemoryChannel. If customers have to use their specific channel, they can add channel to the services, and we pick that instead of our default channels.