This repository has been archived by the owner on Jun 10, 2020. It is now read-only.
Abaranch/request name #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -47,6 +47,8 @@ public static void AddApplicationInsightsTelemetry(this IServiceCollection servi | |||
| rt.Context.InstrumentationKey = svcs.GetService<TelemetryClient>().Context.InstrumentationKey; | |||
| return rt; | |||
| }); | |||
|
|
|||
| //services.AddScoped<RouteContext> | |||
|
Looks good. Please file an issue if you see problem with this pull request. I'll merge it as Anastasia is sick |
SergeyKanzhelev
pushed a commit
that referenced
this pull request
Apr 13, 2015
Abaranch/request name
| using Microsoft.Framework.ConfigurationModel; | ||
| using Microsoft.Framework.DependencyInjection; | ||
| using Microsoft.Framework.Logging; | ||
| using Microsoft.Framework.Logging.Console; | ||
| using SampleWebAppIntegration.Models; | ||
| using FunctionalTestUtils; | ||
| using System; |
There was a problem hiding this comment.
The (ASP.NET Coding Style)[https://github.com/aspnet/Home/wiki/Engineering-guidelines#coding-style-guidelines--general] places System assemblies above other assemblies, such as Microsoft.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added controller can action in request name. Refactored functional tests so we can create different application and add same tests there.