This repository has been archived by the owner on Jul 5, 2020. It is now read-only.
quick pulse endpoint config improvements. #1266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added helper class to build a configuration from xml.
cijothomas
approved these changes
Sep 17, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
QuickPulse Endpoint is set on the
Module.The same value is internally set on the
Processor, but only after the module starts collecting events.This makes it difficult to unit test because it's waiting for data to flow through these classes.
I made a change so that the 'Processor' endpoint is set during initialization methods.
But that was still sensitive to which order the module and endpoint are initialized.
Summary
QuickPulseTelemetryModule.Initialize()will now push the endpoint to the Processor.QuickPulseTelemetryProcessor.ctor()will now pull the endpoint from the Module.Note
These are edge cases discovered while working on connection strings. Connection String support will come in the next PR.