Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert projects to use FrameworkReference #2355

Merged
merged 8 commits into from Aug 11, 2021

Conversation

TimothyMothra
Copy link
Member

Fix Issue #2251

This affects test projects.
Our SDKs target NetStandard2.0, but our Test projects target individual frameworks.

Changes

  • convert test projects to use FrameworkReference

Checklist

  • I ran Unit Tests locally.
  • CHANGELOG.md updated with one line description of the fix, and a link to the original issue if available.

For significant contributions please make sure you have completed the following items:

  • Design discussion issue #
  • Changes in public surface reviewed

The PR will trigger build, unit tests, and functional tests automatically. Please follow these instructions to build and test locally.

Notes for authors:

  • FxCop and other analyzers will fail the build. To see these errors yourself, compile localy using the Release configuration.

Notes for reviewers:

  • We support comment build triggers
    • /AzurePipelines run will queue all builds
    • /AzurePipelines run <pipeline-name> will queue a specific build

<PackageReference Include="Microsoft.AspNetCore.Mvc.Core" Version="1.1.8" />
</ItemGroup>

<ItemGroup Condition=" '$(TargetFramework)' == 'netcoreapp3.1' ">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is correct. By default all ASP.NET Core 2.1 app had IHostingEnvironment reference in startup.cs. As we are retiring .NET Core 2.1 we need to move from IHostingEnvironment to IWebHostEnvironment. This change is not simple, it requires modification to DefaultApplicationInsightsServiceConfigureOptions.cs. This is out of the scope for this PR.

@TimothyMothra TimothyMothra enabled auto-merge (squash) August 10, 2021 23:48
@TimothyMothra TimothyMothra merged commit f2938bb into develop Aug 11, 2021
@TimothyMothra TimothyMothra deleted the tilee/frameworkreference branch August 11, 2021 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants