New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable SDK to create package for auto-instrumentation #2365
Changes from all commits
1682ccd
3f7cb23
f34357a
e4b8772
c6229af
e5fff6a
9048c49
9544b3d
f115ab1
d1581be
f2c7969
2974011
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,39 @@ | ||
# Syntax: https://docs.github.com/en/actions/reference/workflow-syntax-for-github-actions | ||
# .NET CLI: https://docs.microsoft.com/dotnet/core/tools/ | ||
# Description: The purpose of this build is to build and test with redfield flag. | ||
|
||
name: Redfield Sanity Check | ||
|
||
on: | ||
push: | ||
branches: [ master, develop ] | ||
pull_request: | ||
branches: [ master, develop ] | ||
|
||
jobs: | ||
build-test: | ||
|
||
runs-on: ${{ matrix.os }} | ||
|
||
strategy: | ||
fail-fast: false | ||
matrix: | ||
os: [ubuntu-latest] | ||
framework: [netcoreapp3.1,net5.0] | ||
include: | ||
- os: ubuntu-latest | ||
args: "--filter TestCategory!=WindowsOnly" | ||
|
||
steps: | ||
- uses: actions/checkout@v2 | ||
|
||
- name: restore (Base sln) | ||
run: dotnet restore ./BASE/Microsoft.ApplicationInsights.sln | ||
|
||
- name: Build | ||
run: dotnet build -p:Redfield=True ./BASE/Microsoft.ApplicationInsights.sln --configuration Release --no-restore | ||
|
||
- name: Test | ||
id: test1 | ||
continue-on-error: true | ||
run: dotnet test ./BASE/Microsoft.ApplicationInsights.sln --framework ${{ matrix.framework }} --configuration Release --no-build --logger:"console;verbosity=detailed" ${{ matrix.args }} | ||
rajkumar-rangaraj marked this conversation as resolved.
Show resolved
Hide resolved
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -52,7 +52,11 @@ private static bool Initialize() | |
{ | ||
try | ||
{ | ||
#if REDFIELD | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can you open an issue to completely remove this class. it should not be required. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Investigated a little and found methods from this class is called in several places. Did I understand your comment incorrectly? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. yea all the places where this ActivityExtensions is used can be modified to directly use Activity API, instead of doing it via this class. |
||
Assembly.Load(new AssemblyName("System.Diagnostics.DiagnosticSource, Version=4.0.5.0, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51")); | ||
#else | ||
Assembly.Load(new AssemblyName("System.Diagnostics.DiagnosticSource, Version=5.0.0.0, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51")); | ||
#endif | ||
return true; | ||
} | ||
catch (System.IO.FileNotFoundException) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
only building Base sdk?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Running our full test suite here will fail.
We have too many flaky tests and Github Actions does not have a mechanism for retries.
(I'm investigating this in #2345)
If we want to run more test projects here, we must filter those tests.