Update dependencies to remove Newtonsoft.Json. (GHSA-5crp-9r3c-p9vr) #2615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TimothyMothra
changed the title
cijothomas
reviewed
Jun 29, 2022
| @@ -26,7 +26,6 @@ | |||
| <PackageReference Include="Microsoft.AspNetCore.Mvc" Version="2.1.1" /> | |||
| <PackageReference Include="Microsoft.AspNetCore.Mvc.WebApiCompatShim" Version="2.1.1" /> | |||
| <PackageReference Include="Microsoft.AspNetCore.StaticFiles" Version="2.2.0" /> | |||
There was a problem hiding this comment.
separately, these tests still use 2.. It should be bumped to 3.
There was a problem hiding this comment.
I think this is out of scope for this PR. I'll make a note to review all of these when we start assessing .NET 7
cijothomas
reviewed
Jun 29, 2022
cijothomas
approved these changes
Jun 29, 2022
3 tasks
rajkumar-rangaraj
approved these changes
Jun 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2468
Newtonsoft.Jsonhas a security vulnerability that affects all versions < 13.0.1.This is an implicit dependency in the Microsoft.ApplicationInsights.AspNetCore SDK.
Changes
Microsoft.Extensions.Configuration.Jsonfrom v2.1.0 to v3.1.0.Microsoft.Extensions.Configuration.Jsonremoved its dependency onNewtonsoft.Jsonin v3.0.0. v3.0.0 is no longer supported, next lowest supported version is v3.1.0.System.Text.Encodings.Webfrom 4.5.1 to 4.7.2.Upgrading
Microsoft.Extensions.Configuration.Jsonhas a side effect of implicitly upgrading our dependency onSystem.Text.Encodings.Webfrom v4.5.1 to v4.7.0. Unfortunately, v4.7.0 also has a security vulnerability. Next lowest supported version is v4.7.2.