Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support internal and client spans from cosmos db #2712

Merged
merged 5 commits into from
Feb 1, 2023
Merged

Support internal and client spans from cosmos db #2712

merged 5 commits into from
Feb 1, 2023

Conversation

lmolkova
Copy link
Member

@lmolkova lmolkova commented Nov 14, 2022 •
edited

Addressing portal team feedback on new Cosmos instrumentation:

  • in Direct (TCP mode), Cosmos will set Client kind on activities. Even though Cosmos uses TCP, some rare HTTP requests will be made under these activities, so there will be a few occasional client->client spans.
  • In Gateway (HTTP mode), Cosmos will set Internal kind on activities. Users are expected to get both internal (logical) activities and nested HTTP calls.

@lmolkova lmolkova force-pushed the cosmos-internal-client-suppress-nested-http branch from 1a58e53 to 1d4bbd6 Compare November 16, 2022 01:12
@lmolkova lmolkova force-pushed the cosmos-internal-client-suppress-nested-http branch from 1d4bbd6 to 5b62194 Compare January 11, 2023 01:50
sourabh1007
sourabh1007 approved these changes Jan 12, 2023
View reviewed changes
Copy link

@sourabh1007 sourabh1007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!!

reyang
reyang approved these changes Jan 13, 2023
View reviewed changes
Copy link
Member

@reyang reyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a changelog entry.

@lmolkova
Copy link
Member Author

LGTM with a changelog entry.

thank you @reyang! I updated the changelog.

@TimothyMothra TimothyMothra merged commit 18be714 into microsoft:main Feb 1, 2023
@lmolkova
Copy link
Member Author

lmolkova commented Feb 1, 2023

thank you @TimothyMothra !

@TimothyMothra TimothyMothra mentioned this pull request Jan 23, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sourabh1007 sourabh1007 sourabh1007 approved these changes

@reyang reyang reyang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@lmolkova @sourabh1007 @reyang @TimothyMothra