Fix application lockups when calling into app insights from Task sche… #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…duled on UI thread - It is currently possible for the long-running InMemoryTransmitter.Runner task to be executed (and thereby block during WaitOne) on the UI thread when called by a task scheduled on the UI thread. This fix guarantees that InMemoryTransmitter.Runner never blocks the main thread by explicitly specifying TaskScheduler.Default when calling StartNew.
|
Thanks @mousetraps! Can you please re-send this PR for develop branch. Have you tried PersistenceChannel for nodejstools? You can find info about persistence channel on my blog and on [azure docs(https://azure.microsoft.com/documentation/articles/app-insights-windows-desktop/#persistence-channel). I see calls to |
|
Just re-sent for develop branch. In this case, it wasn't actually stemming from our app insights calls, but rather from one in a VS SCC component that we have no control over. We are indeed using PersistenceChannel for NTVS. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…duled
on UI thread
task to be executed (and thereby block during WaitOne) on the UI thread when
called by a task scheduled on the UI thread. This fix guarantees that
InMemoryTransmitter.Runner never blocks the main thread by explicitly
specifying TaskScheduler.Default when calling StartNew.
We recently ran into this issue in Node.js Tools for VS, and managed to work around it by using TaskCreationOptions.HideScheduler, but it would be great to fix it at the source.
And here's a blog post that provides a little more context on the issue:
http://blogs.msdn.com/b/pfxteam/archive/2012/09/22/new-taskcreationoptions-and-taskcontinuationoptions-in-net-4-5.aspx