[Shim] Add Auto-Collection Methods, TelemetryClient, and Config #1175
Conversation
JacksonWeber
changed the title
… setting the context.tags.
JacksonWeber
changed the title
| private _options: ApplicationInsightsOptions; | ||
| private _client: AzureMonitorOpenTelemetryClient; | ||
| private _console: AutoCollectConsole; | ||
| private _exceptions: AutoCollectExceptions; | ||
| private _idGenerator: IdGenerator; | ||
| public context: Context; | ||
| public commonProperties: { [key: string]: string }; // TODO: Add setter so Resources are updated | ||
| public config: IConfig; | ||
|
|
||
| /** | ||
| * Constructs a new client of the client | ||
| * @param setupString the Connection String or Instrumentation Key to use (read from environment variable if not specified) | ||
| */ | ||
| constructor(input?: string | ApplicationInsightsOptions) { |
There was a problem hiding this comment.
Remove ApplicationInsightsOptions parameter from here and leave same structure as old Application Insights
There was a problem hiding this comment.
That will break some things like the functional tests and the configuration example in the distro's README. Are we planning to release the shim after some changes to the distro's user configuration?
src/shim/telemetryClient.ts
Outdated
| } | ||
|
|
||
| public trackNodeHttpRequest(telemetry: Contracts.NodeHttpRequestTelemetry) { | ||
| Logger.getInstance().warn("trackNodeHttpRequest is not implemented and is a no-op."); |
There was a problem hiding this comment.
Why are these not supported? what exactly these were doing before?
There was a problem hiding this comment.
They were some helper functions that called methods (trackRequestSync and trackRequest) inside of the AutoCollectHttpRequests class. Given that OpenTelemetry tracks requests synchronously by default I figured it'd be less confusing to just say these methods weren't supported and have users unify on calling the single trackRequest method.
I think it'd also be fair to implement them all calling the TelemetryClient.trackRequest() or trackDependency methods and just note that these will all be synchronous.
There was a problem hiding this comment.
I'll update the message here to make it more explicit to users the expected alternative method to call.
setup()andstart()so customers can useclient.configbefore runningstart()configproperties to set corresponding values on the Azure Monitor Clientclient.config