Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Functions programming model v4 #1181

Merged
merged 4 commits into from
Sep 6, 2023

Conversation

ejizba
Copy link
Member

@ejizba ejizba commented Aug 11, 2023

Here's a blog post about the v4 model, if you want more info: https://techcommunity.microsoft.com/t5/apps-on-azure-blog/azure-functions-version-4-of-the-node-js-programming-model-is-in/ba-p/3773541

It's currently in preview, but we plan to GA pretty soon. The v4 model cleaned up some of the invocation context and request objects, which is the pretty much the only reason the applicationinsights package has to do anything.

Fixes Azure/azure-functions-nodejs-library#110

My testing

I have a v4 http trigger making this get request inside the function:

await axios.get('https://functionscdn.azureedge.net/public/cli-feed-v4.json');

And it's showing up under the overarching http trigger request in app insights, so I think that means it's working.
Screenshot 2023-08-10 at 5 37 39 PM

@ejizba
Copy link
Member Author

ejizba commented Aug 11, 2023

cc @hossam-nasr @hectorhdzg

@ejizba
Copy link
Member Author

ejizba commented Aug 23, 2023

ping @hectorhdzg

@hectorhdzg
Copy link
Member

@ejizba thanks for updating this, I will take a look soon, I had been kind of busy last couple of days.

Copy link
Member

@hectorhdzg hectorhdzg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for adding support for this

@hectorhdzg hectorhdzg merged commit 4034bb0 into microsoft:develop Sep 6, 2023
8 checks passed
@ejizba ejizba deleted the ej/v4 branch September 6, 2023 23:38
hectorhdzg added a commit to Azure/azure-sdk-for-js that referenced this pull request Sep 19, 2023
…ming model v4 (#27161)

### Packages impacted by this PR
@azure/monitor-opentelemetry

Related to
microsoft/ApplicationInsights-node.js#1181
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Programming model v4: ApplicationInsights:Failed to propagate context in Azure Functions
2 participants