Fix fractional millisecond conversion #274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
JS SDK is using the Let's make the same fix in JS SDK - microsoft/ApplicationInsights-JS#475 |
KamilSzostak
approved these changes
Jun 13, 2017
KamilSzostak
approved these changes
Jun 13, 2017
| @@ -152,6 +152,7 @@ describe("Library/Util", () => { | |||
| test(24 * 60 * 60 * 1000, "1.00:00:00.000", "hours overflow"); | |||
| test(11 * 3600000 + 11 * 60000 + 11111, "11:11:11.111", "all digits"); | |||
| test(5 * 86400000 + 13 * 3600000 + 9 * 60000 + 8 * 1000 + 789, "5.13:09:08.789", "all digits with days"); | |||
| test(1001.505, "00:00:01.001505", "fractional milliseconds"); | |||
There was a problem hiding this comment.
can you add extra unit tests to check 1001.5, 1001.55 (not all precision digits) and 1001.5059 (too many digits, round up?)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #270
@KamilSzostak perhaps JS SDK should use this as well instead of rounding to integer milliseconds?
This change adds support for a variable amount of subsecond precision (min 3 digits, max 7).