Remove AppInsights from Error Stack #464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
markwolff
commented
Dec 5, 2018
markwolff
commented
- Remove Zone artifacts from Error stack shown in console
- Modify error pointer shown in console to inform user that the error was rethrown and originated elsewhere
| @@ -244,6 +244,9 @@ export class CorrelationContextManager { | |||
| if (stackFrames.length > 3) { | |||
| if (stackFrames[2].trim().indexOf("at Error.AppInsightsAsyncCorrelatedErrorWrapper") === 0) { | |||
| stackFrames.splice(2, 1); | |||
| } else if (stackFrames[1].trim().indexOf("at AppInsightsAsyncCorrelatedErrorWrapper.ZoneAwareError") === 0 | |||
There was a problem hiding this comment.
Was this logic previously covered by unit tests? If so, extra cases should be added for this.
OsvaldoRosado
approved these changes
Dec 10, 2018
|
@OsvaldoRosado Do we want to drop this PR if considering zone --> cls? |
|
@markwolff I think this will be useful in the meantime before that change happens, especially since it's a fairly trivial change with a lot of positive impact. |
|
Any idea when this is likely to be released? very welcome change 💯 |
|
@GuyHarwood just published 1.0.8 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.