Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate zonejs dependency #474

Merged
merged 22 commits into from Jan 11, 2019
Merged

Deprecate zonejs dependency #474

merged 22 commits into from Jan 11, 2019

Conversation

markwolff
Copy link
Contributor

@OsvaldoRosado OsvaldoRosado mentioned this pull request Jan 8, 2019
Closed
@OsvaldoRosado
Copy link
Member

OsvaldoRosado commented Jan 8, 2019 •
edited

Should our HTTP patching be updated as well to call bindEmitter? We'd probably want to put it through a layer of abstraction in CorrelationContextManager of course

@markwolff markwolff changed the title Deprecate zonejs dependency WIP: Deprecate zonejs dependency Jan 8, 2019
OsvaldoRosado
OsvaldoRosado reviewed Jan 10, 2019
View reviewed changes
.travis.yml Outdated Show resolved Hide resolved
@markwolff markwolff changed the title WIP: Deprecate zonejs dependency Deprecate zonejs dependency Jan 11, 2019
@OsvaldoRosado OsvaldoRosado mentioned this pull request Jan 11, 2019
Closed
OsvaldoRosado
OsvaldoRosado reviewed Jan 11, 2019
View reviewed changes
Tests/FunctionalTests/Runner/TestValidation.js
@@ -83,7 +83,7 @@ module.exports.TestValidation = class TestValidation {
// Did we find all of the items in the data set?
if (dataSet.length > 1){
Utils.Logging.error("FAILED EXPECTATION - Unexpected child telemetry item(s)!");
Utils.Logging.error(JSON.stringify(dataSet));
Utils.Logging.error(JSON.stringify(dataSet, null, 2));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does this change do?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pretty prints the errors for my sake

@OsvaldoRosado
Copy link
Member

Not a blocker for this PR. But before a stable release we should expose a switch on setAutoDependencyCorrelation to force continuation-local-storage vs cls-hooked.

@markwolff markwolff merged commit 1811f46 into develop Jan 11, 2019
@markwolff markwolff deleted the users/markwolff/remove-zone branch January 11, 2019 18:53
@markwolff markwolff mentioned this pull request Jan 14, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OsvaldoRosado OsvaldoRosado OsvaldoRosado approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@markwolff @OsvaldoRosado