Change Statsbeat long metrics interval #924
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heyams
reviewed
Mar 16, 2022
| @@ -17,7 +17,7 @@ class Statsbeat { | |||
| public static NON_EU_CONNECTION_STRING = "InstrumentationKey=c4a29126-a7cb-47e5-b348-11414998b11e;IngestionEndpoint=https://westus-0.in.applicationinsights.azure.com"; | |||
| public static EU_CONNECTION_STRING = "InstrumentationKey=7dc56bab-3c0c-4e9f-9ebb-d1acadee8d0f;IngestionEndpoint=https://westeurope-5.in.applicationinsights.azure.com"; | |||
| public static STATS_COLLECTION_SHORT_INTERVAL: number = 900000; // 15 minutes | |||
| public static STATS_COLLECTION_LONG_INTERVAL: number = 1440000; // 1 day | |||
lzchen
approved these changes
Mar 16, 2022
ramthi
reviewed
Mar 30, 2022
| @@ -17,7 +17,7 @@ class Statsbeat { | |||
| public static NON_EU_CONNECTION_STRING = "InstrumentationKey=c4a29126-a7cb-47e5-b348-11414998b11e;IngestionEndpoint=https://westus-0.in.applicationinsights.azure.com"; | |||
| public static EU_CONNECTION_STRING = "InstrumentationKey=7dc56bab-3c0c-4e9f-9ebb-d1acadee8d0f;IngestionEndpoint=https://westeurope-5.in.applicationinsights.azure.com"; | |||
| public static STATS_COLLECTION_SHORT_INTERVAL: number = 900000; // 15 minutes | |||
| public static STATS_COLLECTION_LONG_INTERVAL: number = 1440000; // 1 day | |||
| public static STATS_COLLECTION_LONG_INTERVAL: number = 86400000; // 1 day | |||
There was a problem hiding this comment.
After being burnt by similar issues a few times, I made it practice to name the variable with proper suffix. It helped PRs catch any issues quickly as well. Eg: STATS_COLLECTION_LONG_INTERVAL_MILLISEC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Other network errors are being triggered outside of restricted network environment disabling the feature.