Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automatically highlight the line with finding, not the first line of the snippet #278

Closed
gfs opened this issue Sep 2, 2020 · 1 comment
Closed

Automatically highlight the line with finding, not the first line of the snippet #278

gfs opened this issue Sep 2, 2020 · 1 comment
Labels
enhancement New feature or request

Comments

@gfs
Copy link
Contributor

gfs commented Sep 2, 2020

For example, in the following the SerializeObject line is the found line, and should be highlighted. Highlighting the first line is confusing as it draws attention to the context rather than the actual finding.

image
@gfs gfs added the enhancement New feature or request label Sep 2, 2020
guyacosta pushed a commit that referenced this issue Sep 21, 2020
Fixes for #259, #278. Includes correction for unique tags option that…
75ca26b 
… was not functioning right due to clause misidentification. Improves code by reducing near redundant ScanResult structure to use MatchResult directly and avoid duplication. Adds back 3 test cases post OAT integration.
@guyacosta guyacosta mentioned this issue Sep 21, 2020
Merged
guyacosta added a commit that referenced this issue Sep 21, 2020
@guyacosta
Fixes for #259, #278. Includes correction for unique tags option that…
79f4b09 
… was not functioning right due to clause misidentification. Improves code by reducing near redundant ScanResult structure to use MatchResult directly and avoid duplication. Adds back 3 test cases post OAT integration. (#292)
@guyacosta
Copy link
Contributor

Fixed finally

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gfs @guyacosta