Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency list values in JSON and Text reports not 100% accurate #293

Closed
guyacosta opened this issue Sep 21, 2020 · 1 comment
Closed
Assignees
Labels
bug Something isn't working

Comments

@guyacosta
Copy link
Contributor

Describe the bug
Dependencies reported in the json and text formats often have incorrect values. The related rules need to be reviewed for accuracy. See bolded examples below.

To Reproduce
Steps to reproduce the behavior:
Really just depends on the source code that is scanned

Expected behavior
Only actual includes, required etc. dependency files should be output

Screenshots
Example content:
"NJsonSchema.Validation.FormatValidators",
"StreamReader sr = new StreamReader(serializedStream.Content)",
"System",
"System.Collections.Concurrent",
"System.Net",
"System.Threading",
"System.Threading.Tasks",
"var aggregate = await CreateAggregateAsync(scope.ServiceProvider.GetRequiredService<IAggregateRepository>(), descriptor, command).ConfigureAwait(false)",
"var cts = new CancellationTokenSource()",
"var file = File.CreateText(filePath)",
"var file = File.OpenText(path)",

@guyacosta
Copy link
Contributor Author

Improved it quite a bit. Hard to get 100% but we're within our accuracy range.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant