Reviewed the rules. Removed some duplicates and fixed some typos.

[parsiya]

• cryptography
  • algorithm_implementation.json: First and second rules are the same. They both look for a SHA1 constant.
    • Removed the first rule.
  • crypto_currency.json: markleroot -> merkleroot
  • external_libraries.json: Crypographic -> Cryptographic.
  • random.json: Crypgraphy -> Cryptography.
  • crypto_currency.json: Cryptograpy to Cryptography.
• data_types
  • secrets.json: password and access_token are repeated in the patterns of the same rule on lines 12 and 30.
    • Removed password and access_token from line 12.
  • sensitive.json: spouce -> spouse.
  • financial.json: deuch-mark -> deutsche-mark
• frameworks/python.json:
  • Pryamid -> Pyramid.
  • Line 34 - remove trailing comma. "confidence": "high", -> "confidence": "high".
• general
  • code_metrics.json: pyton to python.

---

Verified the rules.

$ ApplicationInspector.CLI.exe verifyrules -i -r \removed\local\path\to\ApplicationInspector\AppInspector\rules\default
Microsoft Application Inspector 1.1.10+8d4d8e826d
Verify Rules command running
Verify rules succeeded
Verify Rules command completed

[gfs]

Thank you for your contribution. At first glance this looks great.

[guyacosta]

Agreed. Thanks for submitting -approved.