Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not allow account label to be modified in connect with Connection string #31

Closed
xyh1 opened this issue Mar 31, 2018 · 1 comment
Closed
Assignees
Labels
💡 feature request New feature or request ✅ merged A fix for this issue has been merged
Milestone

Comments

@xyh1
Copy link

xyh1 commented Mar 31, 2018

Storage Explorer Version: 0.9.6

OS Version: Windows 10

Steps to Reproduce:

  1. Right Click "Storage Accounts"
  2. Select "Connect to Azure Storage"
  3. Select "Use a connection string or a shared access signature URI"
  4. Enter "Connection string:"
  5. Modify Account Label to be anything you want, invalid account name with uppercase letters and or special characters

Expected Experience:
Do not allow Account label to be modified as the connection string has everything that the customer needs already. The account label overwrites the account name in the connection string

Connection string should be the only input allowed.

Actual Experience:
Able to successfully mount invalid accounts names, which modified the connection string

image
image

@MRayermannMSFT MRayermannMSFT added the 💡 feature request New feature or request label Apr 20, 2018
@MRayermannMSFT MRayermannMSFT added this to the 1.2.0 milestone Apr 23, 2018
@MRayermannMSFT MRayermannMSFT modified the milestones: 1.2.0, 1.3.0 May 10, 2018
@craxal craxal modified the milestones: 1.3.0, 1.4.0 Jun 13, 2018
@MRayermannMSFT
Copy link
Member

Merged into @craxal 's feature branch.

@MRayermannMSFT MRayermannMSFT added the ✅ merged A fix for this issue has been merged label Jul 10, 2018
@craxal craxal closed this as completed Jul 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💡 feature request New feature or request ✅ merged A fix for this issue has been merged
Projects
None yet
Development

No branches or pull requests

3 participants