Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Airlock UI: filter requests #2730

Merged
merged 11 commits into from
Oct 12, 2022
Merged

Conversation

jjgriff93
Copy link
Collaborator

Resolves #2511

and resolves #2696 & resolves #2695

What is being addressed

This PR adds the ability to filter by the requestType and status fields. It also implements sorting on the api side to allow for joint filter and sorted requests, and paves the way for pagination in a future update.

How is this addressed

  • Added new UI into the table display to present a filter and sort context menu
  • Added filtering logic to api calls
  • Re-modelled the state management in the component and api calls on filter/sort changes
  • Added request sorting to the API
  • Updated changelog

@jjgriff93
Copy link
Collaborator Author

/test

@jjgriff93 jjgriff93 enabled auto-merge (squash) October 12, 2022 11:28
@github-actions
Copy link

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/3234292170 (with refid ebcd6d35)

(in response to this comment from @jjgriff93)

@github-actions
Copy link

github-actions bot commented Oct 12, 2022

Unit Test Results

513 tests   513 ✔️  16s ⏱️
    1 suites      0 💤
    1 files        0

Results for commit 583d56b.

♻️ This comment has been updated with latest results.

@jjgriff93
Copy link
Collaborator Author

jjgriff93 commented Oct 12, 2022

Skipping tests as previous tests ran successfully before small md change went into main requiring merge (https://github.com/microsoft/AzureTRE/actions/runs/3234292170)

@jjgriff93
Copy link
Collaborator Author

/test-force-approve

@github-actions
Copy link

🤖 pr-bot 🤖

✅ Marking tests as complete (for commit 583d56b)

(in response to this comment from @jjgriff93)

@jjgriff93 jjgriff93 merged commit 680d35a into main Oct 12, 2022
@jjgriff93 jjgriff93 deleted the jjgriff93/2511-ui-airlock-filter_requests branch October 12, 2022 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants