Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use K4A timestamps as input to the ROS timestamps #21

Closed
skalldri opened this issue Jul 1, 2019 · 0 comments · Fixed by #35
Closed

Use K4A timestamps as input to the ROS timestamps #21

skalldri opened this issue Jul 1, 2019 · 0 comments · Fixed by #35
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed triage approved The Issue has been reviewed and approved for development by the Azure Kinect ROS Driver Team

Comments

@skalldri
Copy link
Contributor

skalldri commented Jul 1, 2019

Currently, ROS timestamps are computer by capturing ros::Time::now() as soon as a capture arrives, and using that time for all data emitted from that capture. To better synchronize the IMU and RGB/Depth captures, and to eliminate variability introduced by ROS, we should use the K4A timestamps as input to produce the ROS timestamp.
@skalldri skalldri added enhancement New feature or request triage needed The Issue still needs to be reviewed by the Azure Kinect ROS Driver Team good first issue Good for newcomers help wanted Extra attention is needed triage approved The Issue has been reviewed and approved for development by the Azure Kinect ROS Driver Team and removed triage needed The Issue still needs to be reviewed by the Azure Kinect ROS Driver Team labels Jul 1, 2019
zchenpds added a commit to zchenpds/Azure_Kinect_ROS_Driver that referenced this issue Jul 29, 2019
@zchenpds
fix microsoft#21
ed4d34f
zchenpds added a commit to zchenpds/Azure_Kinect_ROS_Driver that referenced this issue Jul 30, 2019
@zchenpds
Fix issue microsoft#21
dd9e269
zchenpds added a commit to zchenpds/Azure_Kinect_ROS_Driver that referenced this issue Jul 30, 2019
@zchenpds
fix microsoft#21
fa184e9
@zchenpds zchenpds mentioned this issue Jul 30, 2019
Merged
5 tasks
skalldri pushed a commit that referenced this issue Aug 9, 2019
@zchenpds
Fix #21 (#35)
300d7f2
@skalldri skalldri mentioned this issue Aug 22, 2019
Closed
ooeygui pushed a commit to ooeygui/Azure_Kinect_ROS_Driver that referenced this issue Apr 18, 2022
@zchenpds @ooeygui
Fix microsoft#21 (microsoft#35)
0b0fbf5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed triage approved The Issue has been reviewed and approved for development by the Azure Kinect ROS Driver Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix microsoft/Azure_Kinect_ROS_Driver#21 zchenpds/Azure_Kinect_ROS_Driver
1 participant
@skalldri