New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4.5 Samples]: Remove logger
from the Node.js samples
#1465
Comments
logger
from the Node.js sampleslogger
from the Node.js samples
May ask for some clarification?
My understanding was that the logger argument served the purpose of parity with the C# samples, and also the purpose of allowing something other than Is this no longer needed? |
What is the expected change for this issue? I have the same question as Kyle. Does this mean it's expected to remove the logger constructor arg, and replace calls to it in each bot with a call to console.log? |
Yes. We were being too clever. let's just use console.log as it's the only logger we use in the js/ts samples |
Branch: samples-work-in-progress
Sample information
Describe the bug
The wrapper around
console
(i.e.const logger = console;
) is superfluous. We're going to back it out and instead callconsole.log()
or the applicableconsole
method as needed.logger
as an argument will not be passed to the Bot constructors, nor will it continue to exist.To Reproduce
Steps to reproduce the behavior:
index.js/ts
for thesampleconst logger = console;
[bug]
The text was updated successfully, but these errors were encountered: