Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Subscription key in C# #14 readme #556

Closed
JonathanFingold opened this issue Sep 26, 2018 · 0 comments · Fixed by #604
Closed

Subscription key in C# #14 readme #556

JonathanFingold opened this issue Sep 26, 2018 · 0 comments · Fixed by #604
Assignees
@stevengum
Labels
bug Indicates an unexpected problem or an unintended behavior.

Comments

@JonathanFingold
Copy link
Contributor

JonathanFingold commented Sep 26, 2018 •
edited
Loading

Sample information

  1. Sample type: samples
  2. Sample language: dotnetcore
  3. Sample name: 14.nlp-with-dispatch

Describe the bug

Last step in Configure QnA Maker service includes a hard-coded subscription key instead of a placeholder.

To Reproduce

Steps to reproduce the behavior:

  1. follow the above link.
  2. look at the last line of the command line code.

Expected behavior

Use <placeholder-text> here instead.
@cleemullins cleemullins added bug Indicates an unexpected problem or an unintended behavior. approved labels Sep 27, 2018
sgellock added a commit that referenced this issue Oct 3, 2018
@sgellock
Fixes 556 - Subscription key in C# #14 readme #556
3347427 
- remove subscription key
- fix markdown formatting
@sgellock sgellock mentioned this issue Oct 3, 2018
Merged
sgellock added a commit that referenced this issue Oct 3, 2018
@sgellock
Fixes 556 - Subscription key in C# #14 readme #556 (#604)
4206760 
- remove subscription key
- fix markdown formatting
ckkashyap pushed a commit that referenced this issue Oct 17, 2018
@sgellock
Fixes 556 - Subscription key in C# #14 readme #556 (#604)
d81c319 
- remove subscription key
- fix markdown formatting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stevengum stevengum

Labels
bug Indicates an unexpected problem or an unintended behavior.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes 556 - Subscription key in C# #14 readme #556 microsoft/BotBuilder-Samples
3 participants
@cleemullins @stevengum @JonathanFingold