Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#3349] Samples missing deployment templates (template-with-new-rg) - csharp_dotnetcore #3466

Conversation

sw-joelmut
Copy link
Collaborator

Addresses #3349

Proposed Changes

This PR adds the bots' deployment templates (template-with-new-rg.json) under the samples/csharp_dotnetcore folder using the new Azure Bot resource instead of the Bot Channel Registration.

Detailed Changes

Added the ARM templates of the following samples:

  • 14.nlp-with-orchestrator
  • 42.scaleout
  • 43.complex-dialog
  • 44.prompt-users-for-input
  • 45.state-management
  • 50.teams-messaging-extensions-search
  • 51.teams-messaging-extensions-action
  • 52.teams-messaging-extensions-search-auth-config
  • 53.teams-messaging-extensions-action-preview
  • 54.teams-task-module
  • 56.teams-file-upload

Bot that were not added:

  • 01.console-echo => Console Bot
  • 13.core-bot.tests => Test project of the core-bot
  • 40.timex-resolution => Console Bot

Testing

The following images show two bots working with the new ARM Templates.
image
image

Copy link
Contributor

@BruceHaley BruceHaley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@mrivera-ms mrivera-ms merged commit 9d5676e into main Aug 31, 2021
@mrivera-ms mrivera-ms deleted the southworks/add/deployment-templates-samples-csharp-dotnetcore-newrg branch August 31, 2021 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants