Skip to content

Commit

Permalink
fix: Teaching bubble missing content (#7764)
Browse files Browse the repository at this point in the history
* fix: Teaching bubble missing content

* Fix item ref

Co-authored-by: Ben Yackley <61990921+beyackle@users.noreply.github.com>
Co-authored-by: Soroush <hatpick@gmail.com>
  • Loading branch information
3 people committed May 22, 2021
1 parent 830efb8 commit 87bbeda
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 2 deletions.
2 changes: 1 addition & 1 deletion Composer/packages/client/src/Onboarding/content.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -168,7 +168,7 @@ export const getTeachingBubble = (id: string | undefined): TeachingBubble => {
},
};

case 'projectSettings':
case 'publish':
return {
content: formatMessage('Publish your bot to Azure and manage published bots here.'),
headline: formatMessage('Configure and publish'),
Expand Down
4 changes: 3 additions & 1 deletion Composer/packages/client/src/components/NavItem.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,9 @@ export const NavItem: React.FC<INavItemProps> = (props) => {

const active = (pathname.startsWith(to) || match?.test(pathname)) ?? false;

const addRef = useCallback((ref) => onboardingAddCoachMarkRef({ [`nav${labelName.replace(' ', '')}`]: ref }), []);
const addRef = useCallback((ref) => onboardingAddCoachMarkRef({ [`nav${labelName.replace(' ', '')}`]: ref }), [
labelName,
]);

const getIcon = (iconName: string) => {
let navIcon;
Expand Down

0 comments on commit 87bbeda

Please sign in to comment.