Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple ChoicInput #1907

Closed
DesignPolice opened this issue Jan 27, 2020 · 5 comments
Closed

Multiple ChoicInput #1907

DesignPolice opened this issue Jan 27, 2020 · 5 comments
Assignees
Labels
R8 Release 8 - March 16th, 2020
Projects

Comments

@DesignPolice
Copy link

Hello,

Just another spacing issue on this node, when it add 3 items to a ListType - spacing around the boxes needs to change. I have spec'd out the spacing on all of the node, and it's options.

Should be a pretty easy fix.

Thanks again.

Screen Shot 2020-01-27 at 10 52 37 AM

MacOS 10.15.2
Chrome
Stable

@DesignPolice DesignPolice added the Needs-triage A new issue that require triage label Jan 27, 2020
@cwhitten cwhitten added R8 Release 8 - March 16th, 2020 and removed Needs-triage A new issue that require triage labels Feb 1, 2020
@hibrenda hibrenda added this to To do in Sprint 21 via automation Feb 4, 2020
@yeze322
Copy link
Contributor

yeze322 commented Feb 6, 2020

Quote Mark's comments #1954 (comment)

Hey Alan,

not sure why I didn't get an email on this - I need to check my email settings. Sorry to not get back to you sooner.

I have a couple of current issues that also have I have noticed a similar treatment, I would love to just make a couple of tweaks.

The top corners on the nodes have a corner radius of 2px - the hoover outline should have that as well.

I have mocked up some screen shots on these two.

ChoiceInput Node Edit #1905 - these will need changes on other nodes

Hoover State on Nodes #1904 https://github.com/microsoft/BotFramework-Composer/issues/1904

but also attached here.

reach out if that you would like more clarity... happy to help out. Thank you!
M

screen grab

@alanlong9278
Copy link
Contributor

hey, @DesignPolice , Could u send the latest figma for me, I wanna to check all the node ui with it.

@DesignPolice
Copy link
Author

Hi Alan. Will do, I will be in the office in about :30 minutes - thanks

@DesignPolice
Copy link
Author

Here you go Alan...
let me know if you have any questions. Always happy to chat
https://www.figma.com/file/Ux0vucOvaLL2xH22WpFgV65X/MarcB_Composer-UI?node-id=3276%3A95

@hibrenda hibrenda moved this from To do to In progress in Sprint 21 Feb 10, 2020
@cwhitten
Copy link
Member

addressed in #1954

Sprint 21 automation moved this from In progress to Done Feb 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
R8 Release 8 - March 16th, 2020
Projects
No open projects
Sprint 21
  
Done
Development

No branches or pull requests

5 participants