style: update multiple choice input node style #1954
Conversation
alanlong9278
requested review from
a-b-r-o-w-n,
boydc2014,
cwhitten and
yeze322
as code owners
a-b-r-o-w-n
changed the title
|
I believe we need to add a border radius to the think blue border on the top node edges. cc @DesignPolice |
|
Hey Alan, not sure why I didn't get an email on this - I need to check my email settings. Sorry to not get back to you sooner. I have a couple of current issues that also have I have noticed a similar treatment, I would love to just make a couple of tweaks. The top corners on the nodes have a corner radius of 2px - the hoover outline should have that as well. I have mocked up some screen shots on these two. ChoiceInput Node Edit #1905 - these will need changes on other nodes Hoover State on Nodes #1904 https://github.com/microsoft/BotFramework-Composer/issues/1904 but also attached here. reach out if that you would like more clarity... happy to help out. Thank you!
|
| @@ -21,7 +21,7 @@ export const ChoiceInputChoices = ({ choices }) => { | |||
| } | |||
|
|
|||
| return ( | |||
| <div data-testid="ChoiceInput" css={{ padding: '0 0 8px 45px' }}> | |||
| <div data-testid="ChoiceInput" css={{ padding: '0 0 16px 29px' }}> | |||
There was a problem hiding this comment.
can this value be calculated from some constants?
There was a problem hiding this comment.
@yeze322 I'm not sure how to answer that... the goal is that ideally things are all multiples of 4.
I'm not a math guy, but happy to try and help if there is some sort of ratio you want to make that seems like a good idea... or if switching to SVG files makes life easier for you?
There was a problem hiding this comment.
@DesignPolice Thanks Marc! I think your design has already covered those pixel numbers. Programmatically, we need some code optimization to align to your design.
alanlong9278
changed the title
alanlong9278
force-pushed
the
julong/choiceinput
branch
from
3563aa3
to
a92dfda
Compare
Description
UI about multiple choice input align with design.
Task Item
closes #1907
Screenshots