Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Accessibility][Name, Role, Value - Flow Chart]: Name is not defined for 'More Option' button. #2009

Closed
Padmini171991 opened this issue Feb 19, 2020 · 8 comments

Comments

@Padmini171991
Copy link

Padmini171991 commented Feb 19, 2020

User Experience
Users who rely on AT will face difficulty to interact with the webpage if the name of the controls are not defined properly. As well as if the arrow's name's are not defined how the AT dependent user will know the flow.

Test Environment
Browser: Microsoft Edge Canary Version: 82.0.425.0 (Official build)
OS build: 2004 (19564.1005)
Screen Reader: Narrator
URL: Bot Framework Composer
Prerequisite Here

Actual Result
Name of the "More Option" is not defined. As well as the name is not defined for the the arrow's and the end node.

Expected:
The name should be defined for all the controls and the arrows so that the user will know the flow of the arrow.
Note: Same issue is repro within 'Bot responses' and 'User Input. Refer attachmentMAS4.1.2_Bot responses_K4W (1).zip

Repro Steps:

  1. Open the above mentioned URL in EDGE.
  2. Select 'Design Flow' from left navigation.
  3. Now, navigate to '+' button with tab in the flow chart.
  4. Observe the issue.

MAS Impacted: MAS4.1.2

Attachment:
Name is not defined for end node and arrow's
More option buttons

@Padmini171991 Padmini171991 added the Needs-triage A new issue that require triage label Feb 19, 2020
@Padmini171991 Padmini171991 changed the title Test bug for Bot emulator composer [Accessibility][Name, Role, Value - Flow Chart]: Name is not defined for 'More Option' button. Feb 19, 2020
@hibrenda hibrenda removed the Needs-triage A new issue that require triage label Feb 20, 2020
@cwhitten cwhitten added this to To do - Visual Editor in BUILD '20 a11y Feb 25, 2020
@cwhitten cwhitten added the Fixed label Mar 5, 2020
@cwhitten cwhitten moved this from To do - Visual Editor (Ze, Alan) to Waiting for verification in BUILD '20 a11y Mar 6, 2020
@ashish315
Copy link

@cwhitten Issue still repro, cross checked with 'Master' botframework composer.

@ashish315 ashish315 removed the Fixed label Mar 12, 2020
@corinagum corinagum moved this from Waiting for verification to To do - Visual Editor (Ze, Alan) in BUILD '20 a11y Mar 12, 2020
@alanlong9278
Copy link
Contributor

@ashish315 hi, I checked with master branch, there are name property in the more options , arrow and end node.
image
image

@corinagum
Copy link
Contributor

image

I am able to reproduce this issue. These nodes/button do not have aria-label assigned. This means that the AT does not have information to announce. data-name and name are not announced by AT.

As another note, please do not add aria-labels to the SVG. The SVG should be hidden from the AT (aria-hidden), and a parent div should have the label.

@corinagum corinagum moved this from To do - Visual Editor (Ze, Alan) to In review in BUILD '20 a11y Apr 10, 2020
@corinagum
Copy link
Contributor

@Padmini171991 could you clarify the need for the end arrow + node to have a name defined? Is this because the non-visual user must know when reaching the end of the step editor? Thank you.

@alanlong9278
Copy link
Contributor

alanlong9278 commented Apr 13, 2020

arrow ,+ node is a svg node, as the notice says: do not have label in svg node, so we can not add labels. @Padmini171991 @corinagum

@ashish315
Copy link

@alanlong9278 So, is it by design???

@corinagum
Copy link
Contributor

@ashish315 I believe this is by design. With mouse (and keyboard) the arrow+ does not receive focus, so I think aria-label is unnecessary. @alanlong9278 please correct me if I am wrong. :)

@cwhitten cwhitten added the Fixed label Apr 13, 2020
@corinagum corinagum moved this from In review to Waiting for verification in BUILD '20 a11y Apr 13, 2020
@ashish315
Copy link

As this is by design. So, HCL is closing the issue.

@cwhitten cwhitten moved this from Waiting for verification to Done in BUILD '20 a11y Apr 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

No branches or pull requests

8 participants