Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

a11y: Add name for arrow, nodeMenu and endNode #2131

Merged
merged 4 commits into from
Mar 5, 2020

Conversation

alanlong9278
Copy link
Contributor

@alanlong9278 alanlong9278 commented Feb 28, 2020

Description

Add name for arrow, nodeMenu and endNode

Task Item

Closes #2009

Screenshots

image
image

@github-actions
Copy link

Coverage Status

Coverage remained the same at 42.071% when pulling dfc6022 on julong/nameForComponent into 8b0510b on master.

@corinagum
Copy link
Contributor

@alanlong9278, please remove the 'closes' from your description:
image

Since the a11y team will need to verify, we don't want to close the issues until they are able to do a pass. :) thank you!

@cwhitten cwhitten changed the title chore: Add name for arrow, nodeMenu and endNode ally: Add name for arrow, nodeMenu and endNode Mar 4, 2020
@corinagum corinagum changed the title ally: Add name for arrow, nodeMenu and endNode a11y: Add name for arrow, nodeMenu and endNode Mar 5, 2020
@cwhitten cwhitten changed the title a11y: Add name for arrow, nodeMenu and endNode ally: Add name for arrow, nodeMenu and endNode Mar 5, 2020
@cwhitten cwhitten changed the title ally: Add name for arrow, nodeMenu and endNode a11y: Add name for arrow, nodeMenu and endNode Mar 5, 2020
@cwhitten cwhitten merged commit 1bea213 into master Mar 5, 2020
@cwhitten cwhitten deleted the julong/nameForComponent branch March 5, 2020 23:52
@cwhitten cwhitten mentioned this pull request Mar 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants